CRM-18286 - Use localStorage to remember datatable page length #8298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemanw
force-pushed
the
CRM-18286
branch
3 times, most recently
from
3467445
to
cf9fd95
Compare
| // Strip the ids from ajax urls to make pageLength storage more generic | ||
| function simplifyUrl(ajax) { | ||
| // Datatables ajax prop could be a url string or an object containing the url | ||
| var url = typeof ajax === 'object' ? ajax.url : ajax; |
There was a problem hiding this comment.
I think this could be simplified as:
var url = ajax.url || ajax
|
Successfully replicated the issue on the On the PR's branch, the issue is gone, the datatable page length being remembered after page refresh on all the major browsers |
| function simplifyUrl(ajax) { | ||
| // Datatables ajax prop could be a url string or an object containing the url | ||
| var url = typeof ajax === 'object' ? ajax.url : ajax; | ||
| return typeof url === 'string' ? url.replace(/[&?]\w*id=\d+/g, '') : null; |
There was a problem hiding this comment.
What if you remove the querystring altogether? Is that too generic?
There was a problem hiding this comment.
Yes, it would apply to all datatables (at least in WP and Joomla where the civi path is part of the query string).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-18286