Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-18482 import - don't fill acl_contact_cache immediately before em… #8266

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

eileenmcnaughton
Copy link
Contributor

…ptying it

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 do you want to do QA on this? I have put it on your ubox.

The point of this is to remove a case where acl caches are rebuilt, this reducing a potential cause of deadlocks. It seems to me that CRM_Contact_BAO_Contact_Utils::clearContactCaches() removes the entries created a few lines earlier by the call to CRM_ACL_BAO_Cache::updateEntry($userID);

I guess one question that is open in my mind is how this would be affected by moving to scheduled rebuilds of caches rather than opportunistic. I'm not sure that changes this PR, just keeps it on our radar for inclusion in that one.

@seamuslee001
Copy link
Contributor

@andrew-cormick-dockery just FYI

@litespeedmarc
Copy link
Contributor

@colemanw, this seems pretty simple fix from a pretty reliable contributor. Review looks simple enough. Can we move it along for merge please?

@colemanw colemanw merged commit c2eb0d9 into civicrm:master Sep 27, 2016
@eileenmcnaughton eileenmcnaughton deleted the CRM-18482 branch September 27, 2016 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants