CRM-18467 Set amount to appear on pay-later receipt

[kenwest]

The amount is passed to this function as $form->_params['amount']

If $form->_values['amount'] is not set, then the Amount won't print on the receipt.

The previous if-statement handles the case when the amount is zero. So this elseif checks whether $form->_values['amount'] is empty, and if it is, copies the amount into it.

---

• CRM-18467: Amount doesn't appear on Pay Later receipt

[eileenmcnaughton]

We really need to lock these things in with tests - otherwise these things will just change & start failing again.... can I help you write a unit test?

[kenwest]

Sure Eileen. Perhaps you could point me at one that I could copy and modify?

[eileenmcnaughton]

Assuming you are working on a front end page this is probably a good starting point https://github.com/civicrm/civicrm-core/blob/master/tests/phpunit/api/v3/ContributionPageTest.php#L139

[eileenmcnaughton]

As an aside I have a preference for NOT adding parameters to the $form_values but passing to the next function with an array merge or by doing $sendParams = $form->_values; $sendParams['amount'] = ...

The reason being that things get passed all over the place in post processing & then people tack logic onto them - so I try to reduce the number of things that are set & available in other functions despite not being required in those functions. This is more about how to bring CiviCRM back from where it is than a general coding rule

[monishdeb]

Closing in favor of #8391