Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-18267 upgrade php-font-lib #8165

Closed
wants to merge 2 commits into from
Closed

CRM-18267 upgrade php-font-lib #8165

wants to merge 2 commits into from

Conversation

anuditverma
Copy link

Updated php-font-lib package version to latest 0.4 release.


Updated php-font-lib package version to latest 0.4 release.
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@eileenmcnaughton
Copy link
Contributor

test this please

Changed the source URLs and commit references, now they refer to the latest update.
@eileenmcnaughton
Copy link
Contributor

ok to test

@anuditverma
Copy link
Author

anuditverma commented Apr 20, 2016

Hi Eileen, I just tracked this on jenkins, there is a checkstyle error (No report files were found). I'm not sure what exactly could have caused this. Could you please help me to get over this one ? Thanks

@eileenmcnaughton
Copy link
Contributor

let's re-run the test in case it was unrelated!

@eileenmcnaughton
Copy link
Contributor

test this please

@anuditverma
Copy link
Author

Hi again, Its showing the same, so any problems in my commits then ?

@colemanw
Copy link
Member

Why is composer.json not updated in this PR? Does the lock file take care of version?

@colemanw
Copy link
Member

colemanw commented Apr 21, 2016

The testbot is reporting:

Could not scan for classes inside "/home/jenkins/buildkit/build/core-8165-8vwvc/sites/all/modules/civicrm/vendor/phenx/php-font-lib/classes/" which does not appear to be a file nor a folder

Perhaps the composer update should be re-run from a clean copy of master.

@anuditverma
Copy link
Author

So I need to update composer.json with the latest proposed commit ? And for the second part I guess I need to do this through a new copy of master, again.

@eileenmcnaughton
Copy link
Contributor

that sounds about right - there should be a change to both composer.json & composer.lock & yeah, it's good practice to do a

git pull --rebase origin master

before reworking a patch

@anuditverma
Copy link
Author

anuditverma commented May 6, 2016

Hi, sorry I have been very busy with my major exams, I received Tim's email and I decided to get this one done. I did rebasing and made changes to composer.lock file but while editing composer.json I realized that php-font-lib has not been defined under "require": and I think some of the others are not there too. So do I need to add all other libraries as well that are defined in lock file ?

@anuditverma
Copy link
Author

Submitted a new PR : #8335

@colemanw colemanw closed this May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants