CRM-18424 better amount label for repeat transactions #8157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
CRM-18424
branch
from
308bcf1
to
7b2cc70
Compare
eileenmcnaughton
force-pushed
the
CRM-18424
branch
from
7b2cc70
to
3dafdf1
Compare
Note that this patch also does some minor consolidation, bringing actions that relate to the is_recur checkbox into the same function. I made the total_amount label always present, but sometimes hidden. this saves us having to check for it and also gives is a place to store data consistently. We have been moving towards greater DOM consistency on payment pages
|
@eileenmcnaughton only one issue remaining -
Everything else is working for Event,Membership Contribution price-set and quick-config priceset on online event (also checked the text change for additional participant) and contribution registration page. |
On digging into it I found the showHideAutoRenew function was robust enough to be called in both a hide & a show situation. So, yay, further minor simplification
eileenmcnaughton
force-pushed
the
CRM-18424
branch
from
6007f50
to
de4cd6a
Compare
| function toggleRecur( ) { | ||
| var isRecur = cj('input[id="is_recur"]:checked'); | ||
| var allowAutoRenew = {/literal}'{$allowAutoRenewMembership}'{literal}; | ||
| if ( allowAutoRenew && cj("#auto_renew") ) { |
There was a problem hiding this comment.
@monishdeb I think moving this showHideAutoRenew call up here (out of the later if) solves the regression problem you found. showHideAutoRenew is clever enough to ... show AND hide
|
Yup worked for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this patch also does some minor consolidation, bringing actions that relate to the is_recur checkbox into the same function.
I made the total_amount label always present, but sometimes hidden. this saves us having to check for it and also gives is a place to store data
consistently. We have been moving towards greater DOM consistency on payment pages