Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export relationship custom field CRM-18354 #8076

Closed
wants to merge 2 commits into from

Conversation

sunilpawar
Copy link
Contributor

@monishdeb
Copy link
Member

Can you fix those 2 style warning shown in related test build failure https://test.civicrm.org/job/CiviCRM-Core-PR/8583/checkstyleResult/new/ ?

@seamuslee001
Copy link
Contributor

Can't verify the problem described in the Issue

@totten
Copy link
Member

totten commented May 17, 2016

It sounds like the problem can't be reproduced (based on comments from @jitendrapurohit in JIRA and @seamuslee001 above). Also, the descriptions in JIRA issue and commit message are pretty thin, and I suspect this area has weak test-coverage, so it's really hard to evaluate without seeing it in action.

I'll close the PR for now so that we don't try to review it again. @sunilpawar, if there's an update with more details on how to reproduce or what's going on, please re-open. (If you prefer to keep it open while working on it, that's cool too. Just put "WIP" in the subject-line until it's ready for more review.)

Thanks all!

@totten totten closed this May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants