(WIP) CRM-18323- PCP Search implementation like group search #8045
Conversation
|
Can one of the admins verify this patch? |
| @@ -235,6 +235,10 @@ public static function getStatusMsg() { | |||
| $ret['content'] .= '<br /><br /><strong>' . ts('This recurring contribution is linked to an auto-renew membership. If you cancel it, the associated membership will no longer renew automatically. However, the current membership status will not be affected.') . '</strong>'; | |||
| } | |||
| break; | |||
|
|
|||
There was a problem hiding this comment.
Code style issues? This is super indented =]
|
@Kajakaran as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR if I got someone to QA this PR? |
|
@sqweets would you be willing to do some QA on this search PR? |
|
Joe, I will give it a shot. Are there any guidelines, etc. for doing QA for Thanks, Ellen Hendricks | Developer On Mon, Jun 20, 2016 at 9:55 PM, Joe Murray notifications@github.com
|
|
Wonderful - thanks! And thanks for putting in your .sig... @eileenmcnaughton had mentioned your name but not your handle. There are some guidelines for reviewing you can find on the ReviewerTips tab of https://docs.google.com/spreadsheets/d/1fmHFOZ83ectSPCMWvXwCeJgrw4KpYi8JEV2ZDkd6XDU/edit#gid=616660117 Please also checkout the FAQ and Overview tabs. |
| * @return array | ||
| */ | ||
| public static function getPcpList(&$params) { | ||
| $config = CRM_Core_Config::singleton(); |
There was a problem hiding this comment.
This line should go. It's not used. The codebase does seem to be littered with instantiation of the Config object so there may have been a historical reason but there should not be one now
|
test this please |
|
I took a look through the code & it seems sound - although there are a number of comments I have made - mostly regarding practices we are trying to move away from. The problem from a QA point of view is that there are a number of code style issues (https://test.civicrm.org/job/CiviCRM-Core-PR/10121/console ) preventing the tests from running & hence preventing the sandbox from being built allowing you to test it without having a dev setup (@sqweets ) Normally I think I would put a WIP flag on this until the style issues are resolved and see if VEDA can get that sorted. OTOH this is desirable functionality & if you have a particular interest in this @sqweets then I guess I could fix the style issues in to a new PR for your to test. |
|
@eileenmcnaughton https://github.com/eileenmcnaughton I am willing to Ellen Hendricks | Developer On Tue, Jun 21, 2016 at 4:38 PM, Eileen McNaughton <notifications@github.com
|
|
Let's mark as WIP and wait for code fixes to be made by @Kajakaran or others at VEDA. |
eileenmcnaughton
changed the title
|
ok - please remove wip from the title when updated |
litespeedmarc
added
the
needs-work-not-review-ready
litespeedmarc
changed the title
litespeedmarc
added
needs-work-not-review-ready
|
@sqweets are you still planning to work on this? |
|
I'm closing this because it is stalled. The work is still linked from https://issues.civicrm.org/jira/browse/CRM-18323 so when someone wants to pick it up again it this work can be easily found. However, there is an advantage in closing & re-opening as it goes to the front page of the PR list when it becomes active again |
|
Can one of the admins verify this patch? |
PCP Search screen improved similar to Group Search screen
issue:- If we have too many Personal Campaign Pages, server crashes because search page brings all PCPs every time we navigate to PCP search
Further, PCP search screen has lack of filters like PCP supporter Name, PCP title, Event/Contribution starts, Event/Contribution Ends on and etc.
https://issues.civicrm.org/jira/browse/CRM-18323