Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-17982 - CRM_Core_Config_MagicMerge - Fix warning on demos sites #7774

Merged
merged 2 commits into from
Feb 9, 2016

Conversation

totten
Copy link
Member

@totten totten commented Feb 9, 2016

Apparently, createDir() will return FALSE if the folder already exists or
if the creation-act fails. We only want to display a warning if the
creation-act fails.


https://issues.civicrm.org/jira/browse/CRM-17982

Apparently, createDir() will return FALSE if the folder already exists *or*
if the creation-act fails.  We only want to display a warning if the
creation-act fails.
@totten totten changed the title CRM_Core_Config_MagicMerge - Fix warning on demos sites CRM-17982 - CRM_Core_Config_MagicMerge - Fix warning on demos sites Feb 9, 2016
@colemanw
Copy link
Member

colemanw commented Feb 9, 2016

@totten do you know why testGetModules is failing? I think our PR tests would be green if not for that.

colemanw added a commit that referenced this pull request Feb 9, 2016
CRM-17982 - CRM_Core_Config_MagicMerge - Fix warning on demos sites
@colemanw colemanw merged commit c5906cd into civicrm:master Feb 9, 2016
@totten totten deleted the master-dash-err branch February 9, 2016 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants