CRM-17959 - allow URL to be redirected if the queue ID is invalid but…

[andrew-cormick-dockery]

… the URL ID is OK

[civicrm-builder]

Can one of the admins verify this patch?

[seamuslee001]

Jenkins test this please

Note this should still get core teams's eyes on it

[totten]

jenkins, add to whitelist

[seamuslee001]

Test failures look unrelated to this PR @totten perhaps related to change in phpunit?

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

@totten I think this is OK - any concerns from your side? $turl is not user input so the lack of escaping seems OK

[kcristiano]

tested PR:

Steps to reproduce:

• Create a mailing with external links (eg https://civicrm.org)
• Send mailing
• test that links work properly
• delete rows from civicrm_mailing_event_queue table
• Click links in email again- expected behavior is redirect to sites home page

Condition Reproduced.

Applied patch - Manually. Note @totten doing hub checkout rolled CiviCRM back to a prior version and introduced an unrelated error. Therefore, cherry picking or applying the patch was the only way to go here.

After Patch perform the following steps:

• Go back to email
• click links in email
• They now are resolved properly

Further tests:

• deleted row from civicrm_mailing_trackable_url - Note ID
• Find that ID in email click on that link. Expected to be redirected to home page
• works properly

Also verified with WordPress and Joomla

@eileenmcnaughton PR looks good to merge.

[mlutfy]

Discussed with @seamuslee001, we should use CRM_Utils_Rule::mysqlColumnNameOrAlias() to filter the variable in the SQL query.

We will discuss with Tim and probably open a followup PR to address this.

[eileenmcnaughton]

Thanks guys!

[mlutfy]

For reference, followup SQL fix and test added in : #8516