CRM-17867 - Api4 core patches #7725

colemanw · 2016-02-03T01:06:49Z

Most of api4 is in an extension - these are the changes needed to core.

CRM-17867: Implement new version of the CiviCRM api

colemanw · 2016-02-04T04:02:18Z

jenkins test this please

totten · 2016-02-16T22:03:15Z

@colemanw , for the issue of the kernel test failures, it's OK to change Civi\API\KernelTest::MOCK_VERSION from 99 to 3.

I used a mock-version of 99 to avoid unintentional conflicts between (a) the isolated/fake test entity and (b) the normal runtime entities. However, that was mostly theoretical/preventive, and we're not likely to get a conflict on the Widget.frobnicate API.

https://github.com/civicrm/civicrm-core/blob/master/tests/phpunit/Civi/API/KernelTest.php#L9

totten · 2016-02-17T02:01:20Z

api/v3/utils.php

+  }
+  $query->limit = $options['limit'];
+  $query->offset = $options['offset'];
+  $query->checkPermissions = CRM_Utils_Array::value('check_permissions', $params, FALSE);


Re: the failed test. I don't believe it's a problem with the hook infrastructure. Look at this:

Here in basic_get(), it calls the constructor (new Api3SelectQuery()) and then sets the checkPermissions property.

Inside the constructor, it calls $this->query->where($this->getAclClause(self::MAIN_TABLE_ALIAS, $baoName));. At that point, checkPermissions still has its default value (false).

Inside getAclClause(), it short-circuits because checkPermissions is false.

I took a stab at this with f62e540. It might need a similar patch for Api4SelectQuery.

colemanw · 2016-03-06T22:03:23Z

jenkins, retest this please

eileenmcnaughton · 2016-06-23T04:06:24Z

test this please

eileenmcnaughton · 2016-07-12T00:35:39Z

test this please

litespeedmarc · 2016-09-26T21:18:03Z

Talking with @colemanw today during spring coding. Giving an update this, and hence a heart beat on this patch. It is still alive, he's just had no chance to get to back to Api V4 stuff.

This continues to be WIP, shouldn't get merged yet, until we know more about how ApiV4 will work and is complete -- avoiding to WAGNI core until then.

Recommends to follow-up in a couple months still, leaving open until then

Most of api4 is in an extension - these are the changes needed to core.

seamuslee001 · 2016-10-10T19:36:52Z

Jenkins re test this please

The unconditional translation of financial_type to contribution_type was messing up a few tests. This seems more sensible anyway.

seamuslee001 · 2016-10-10T20:58:48Z

I ran AUG's unit tests against 4.7 with this patch and couldn't see any major errors, Once tests run clean should be fine to merge

seamuslee001 · 2016-10-10T23:12:50Z

api/v3/utils.php

@@ -176,8 +176,13 @@ function civicrm_api3_create_success($values = 1, $params = array(), $entity = N
        $values[$key]['id'] = $item[$lowercase_entity . "_id"];
      }
      if (!empty($item['financial_type_id'])) {
-        //4.3 legacy handling
-        $values[$key]['contribution_type_id'] = $item['financial_type_id'];
+        // 4.3 legacy handling - translate financial_type to contribution_type unless financial_type is explicitly specified.


@colemanw this change is what is breacking one of the syntaxConformanceTests specifically the grant one

my theory is that it is expecting that contribution_type_id should be outputted in the api array and always matches that of the financial_type_id

Fix contribution tests that failed in last run

eileenmcnaughton · 2016-10-11T21:15:20Z

Adding merge on pass per assessment by @seamuslee001 - yay

seamuslee001 · 2016-10-11T21:37:02Z

@eileenmcnaughton we got a pass

eileenmcnaughton · 2016-10-11T21:57:38Z

!!

Core patches have been merged civicrm/civicrm-core#7725

On civicrm/civicrm-core#7725, a lot of changes to support APIv4 were introduced, including changes to the SelectQuery class, which now is abstract and cannot be instantiated. To fix this, the *Select classes now use the Api3SelectQuery class instead.

civicrm-builder added the master label Feb 3, 2016

colemanw added the needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state label Feb 3, 2016

colemanw force-pushed the api4 branch 3 times, most recently from 5e633fd to 91f19f2 Compare February 3, 2016 03:48

colemanw force-pushed the api4 branch 5 times, most recently from e4adbd4 to c6d67d1 Compare February 15, 2016 00:51

colemanw force-pushed the api4 branch from c6d67d1 to b4a79a8 Compare February 16, 2016 21:41

colemanw force-pushed the api4 branch from b4a79a8 to 0de0c3e Compare February 16, 2016 22:30

totten reviewed Feb 17, 2016
View reviewed changes

colemanw force-pushed the api4 branch 3 times, most recently from d7b3ea5 to 5062bbd Compare March 15, 2016 05:51

colemanw mentioned this pull request Mar 27, 2016

CRM-18295: Added entity names as keys to entityFieldNames and updated… #8026

Closed

colemanw force-pushed the api4 branch from ebc623d to 1fbba81 Compare March 29, 2016 21:57

totten mentioned this pull request Apr 6, 2016

Invitation: CiviCRM Release for May 2016 civicrm/release-management#1

Closed

totten mentioned this pull request May 6, 2016

Invitation: CiviCRM Release for June 2016 civicrm/release-management#2

Closed

JoeMurray mentioned this pull request Jul 7, 2016

Invitation: CiviCRM 4.7.10 release August 2016 civicrm/release-management#4

Closed

litespeedmarc changed the title ~~CRM-17867 - Api4 core patches~~ (WIP) CRM-17867 - Api4 core patches Sep 27, 2016

litespeedmarc added needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state and removed needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state labels Sep 27, 2016

colemanw force-pushed the api4 branch from 1fbba81 to 5a9d99a Compare October 9, 2016 20:30

colemanw added 5 commits October 10, 2016 14:15

CRM-17867 - Api4 core patches

8bcc0d8

Most of api4 is in an extension - these are the changes needed to core.

CRM-17867 - Api kernel refactoring

7b81020

CRM-17867 - Api test fixes

34e21ce

CRM-17867 - Set checkPermission before running getAclClause

8e8bf58

Test fix

0248c33

colemanw force-pushed the api4 branch from 5a9d99a to 180a895 Compare October 10, 2016 18:16

Test fix

3313990

The unconditional translation of financial_type to contribution_type was messing up a few tests. This seems more sensible anyway.

colemanw force-pushed the api4 branch from 180a895 to 3313990 Compare October 10, 2016 20:46

seamuslee001 reviewed Oct 10, 2016

View reviewed changes

Fix Syntax Conformance Tests (#2)

258c92c

colemanw changed the title ~~(WIP) CRM-17867 - Api4 core patches~~ CRM-17867 - Api4 core patches Oct 11, 2016

seamuslee001 and others added 3 commits October 12, 2016 07:25

Fix contribution tests that failed in last run

9e6c4b1

Better test fix

257ab38

Merge pull request #3 from seamuslee001/api4-testfix

8b0a65b

Fix contribution tests that failed in last run

eileenmcnaughton added merge on pass and removed needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state labels Oct 11, 2016

eileenmcnaughton merged commit e10c60e into civicrm:master Oct 11, 2016

eileenmcnaughton deleted the api4 branch October 11, 2016 21:57

colemanw added a commit to civicrm/org.civicrm.api4 that referenced this pull request Oct 11, 2016

Update readme.md

cbb88a3

Core patches have been merged civicrm/civicrm-core#7725

colemanw added the CiviCase Backport label Mar 23, 2017

davialexandre mentioned this pull request Apr 18, 2017

PCHR-2113: Make CiviHR 1.7 compatible with CiviCRM 4.7.18 compucorp/civihr#1730

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRM-17867 - Api4 core patches #7725

CRM-17867 - Api4 core patches #7725

colemanw commented Feb 3, 2016

colemanw commented Feb 4, 2016

totten commented Feb 16, 2016

totten Feb 17, 2016

colemanw commented Mar 6, 2016

eileenmcnaughton commented Jun 23, 2016

eileenmcnaughton commented Jul 12, 2016

litespeedmarc commented Sep 26, 2016

seamuslee001 commented Oct 10, 2016

seamuslee001 commented Oct 10, 2016

seamuslee001 Oct 10, 2016

seamuslee001 Oct 10, 2016

eileenmcnaughton commented Oct 11, 2016

seamuslee001 commented Oct 11, 2016

eileenmcnaughton commented Oct 11, 2016

CRM-17867 - Api4 core patches #7725

CRM-17867 - Api4 core patches #7725

Conversation

colemanw commented Feb 3, 2016

colemanw commented Feb 4, 2016

totten commented Feb 16, 2016

totten Feb 17, 2016

Choose a reason for hiding this comment

colemanw commented Mar 6, 2016

eileenmcnaughton commented Jun 23, 2016

eileenmcnaughton commented Jul 12, 2016

litespeedmarc commented Sep 26, 2016

seamuslee001 commented Oct 10, 2016

seamuslee001 commented Oct 10, 2016

seamuslee001 Oct 10, 2016

Choose a reason for hiding this comment

seamuslee001 Oct 10, 2016

Choose a reason for hiding this comment

eileenmcnaughton commented Oct 11, 2016

seamuslee001 commented Oct 11, 2016

eileenmcnaughton commented Oct 11, 2016