CRM-16188, added order api for delete action and test

[pradpnayak]

---

• CRM-16188: Create an order API
  https://issues.civicrm.org/jira/browse/CRM-16188

[eileenmcnaughton]

Just a note here - one way to make this shorter would be

if (!civicrm_api3('Contribution', 'getvalue', array('return' => 'is_test', 'id' => $params['id')) {
throw new ....
}

Note you can be sure $params['id'] will be set due to your aliasing - you don't need to check contribution_id.

Also - I suggest you edit the exception to say only test orders can be deleted.

[pradpnayak]

I had tried with

$result = civicrm_api3('Contribution', 'getvalue', array(
'sequential' => 1,
'return' => array("is_test"),
'id' => 22,
));

I was getting exception error with 'field Array unset or not existing'.

[eileenmcnaughton]

ah I think that might be a bug in the contribution api - no accepting that as a return value

[eileenmcnaughton]

The test fails are unrelated but I think it's worth at minimum expanding the api exception message to state the reason and getting rid of the unnecessary e-notice preventions. The other comments are more in the nice-to-have.

I don't see any larger concerns with this PR

[eileenmcnaughton]

I've updated the title to [needs minor changes] to reflect my comment above - please change to [needs core team review] when you have fixed the exception (& preferably the enotice over-handling)