[unresolved-regression] CRM-17616 - Moving to an arbitrary search page result could lead to incomplete results #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncomplete results
|
Jenkins, retest this please. |
|
In my testing, this PR caused a regression in the dynamic row count radio button. See https://issues.civicrm.org/jira/browse/CRM-17616?focusedCommentId=82845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-82845 |
|
Hey, I edited the title to make it easier for people to see the status of the PR when scrolling the list - when you fix the issue that Dgg identified please re-edit it. (if you really are not going to then it is Ok to close the PR but ensure that links to the relevant commits are on the ticket - the commit links continue to work even if you delete the branch ) |
totten
changed the title
|
Replaced by #8591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial resolution of this problem.
When launching a new search without reset=1, $pageSize is not initialized correctly and is initialized to 50 by default.
There is no regression though because i have used max(500, $pageSize) to enforce at least 500 each time the cache is refreshed.
Next step is to see if we can have $pageSize properly initialized every time.