Fixed webtest for civi-4.6 #5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -262,9 +262,9 @@ public function testChangePaymentInstrument() { | |||
| $this->waitForAjaxContent(); | |||
| //Assertions | |||
| $subtractedTotal = $this->_getPremiumActualCost($contId, NULL, 'Payment Processor Account'); | |||
| $this->assertEquals($subtractedTotal, -$amount, "Verify amount deleted from old account"); | |||
| $this->assertEquals($subtractedTotal, NULL, "Verify amount deleted from old account"); | |||
There was a problem hiding this comment.
I am not sure if its a right fix, please verify the change again !!
There was a problem hiding this comment.
I don't think it's a great fix to check NULL.
Could you try adding 5th parameter as entity table to _getPremiumActualCost functionSomething like$subtractedTotal = $this->_getPremiumActualCost($contId, NULL, 'Payment Processor Account', NULL, 'civicrm_contribution');
Or set $entityTable = 'civicrm-contribution' by default in function _getPremiumActualCost.
HTH
Pradeep
Sent from my BlackBerry 10 smartphone.
|
test build failure is not related to current changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Webtest -
WebTest_ACL_AssignUsersToRolesTest.testAssignUsersToRoles
WebTest_ACL_AssignUsersToRolesTest.testACLforSmartGroups
WebTest_Contact_TaskActionAddToGroupTest.testMultiplePageContactSearchAddContactsToGroup
WebTest_Contribute_UpdateContributionTest.testChangePaymentInstrument