Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#5770 SearchKit - Focus input when editing #32289

Closed
wants to merge 1 commit into from

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 4, 2025

Overview

Fixes dev/core#5770 - Fewer mouseclicks required when inline-editing.

Copy link

civibot bot commented Mar 4, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Mar 4, 2025
Copy link

civibot bot commented Mar 4, 2025

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5770

@colemanw
Copy link
Member Author

colemanw commented Mar 4, 2025

@highfalutin ^

@highfalutin
Copy link
Contributor

Thanks for the attention to this issue, @colemanw! The code changes are appealingly lightweight. On an r-run,

  • This works well with text/integer inputs in "single-field" mode.
  • It works for text/integer inputs in table displays AND list displays.
  • It doesn't work for complex widgets like select2 and datepicker.
  • In "full-row" mode, it works as desired if the first editable column is text/integer and you click on that column.
  • In "full-row" mode, if you click on, say, column 4, which presumably means you want to edit column 4, focus still goes to the first editable column.

See #32291 for my alternative.

@colemanw colemanw closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants