Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify light mode for civicrm.css to fix Standalone logo in Greenwich #32286

Open
wants to merge 1 commit into
base: 6.1
Choose a base branch
from

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Mar 4, 2025

Overview

Tell browser that our non-Riverlea themes dont have darkmode.

Before

  • system components and SVG will respond if the user has set dark mode (in their browser/OS)
  • this causes a particular issue with the logo on Standalone login page if your theme is set to Greenwich and your browser asks for dark mode => you get a dark mode logo (white) on the fixed white background

After

  • in Greenwich, everything inside .crm-container CiviCRM always stays in light mode
  • in Riverlea this gets overridden and handled as per Riverlea's dark mode setting

Comments

I wonder if there is a risk that someone is using Greenwich but has custom components that do respond to dark mode?

Copy link

civibot bot commented Mar 4, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Mar 4, 2025
@ufundo ufundo marked this pull request as ready for review March 4, 2025 08:59
@ufundo ufundo changed the base branch from master to 6.1 March 6, 2025 09:20
@civibot civibot bot added 6.1 and removed master labels Mar 6, 2025
@ufundo
Copy link
Contributor Author

ufundo commented Mar 6, 2025

Pointing at 6.1 because that's where the SVG logo is introduced which is the symptom I'm trying to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant