asofDate gets used as constructor to DateTime which wants a string

[jmcclelland]

Overview

The $asofDate variable defaults to NULL. This variable is later passed to the calcDateFromAge function, which in turn feeds it to the DateTime constructor.

But, the DateTime constructor wants a string, so we can errors.

By updating the default value of the date used to calculate age to be an empty string instead of NULL, it works without errors.

Before

I get errors like the following:

[PHP Deprecation] DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated at /var/www/powerbase/sites/all/modules/civicrm/CRM/Contact/BAO/Query.php:5582

After

No errors!

Comments

The calcDateFromAge function does not seem to be called from anywhere else in the code base. It might be called from extensions which might suggest we should convert from NULL to string in that function but that could happen later if needed.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[yashodha]

@jmcclelland looks good, merging this PR