[REF] Fix showing Main Email field only hwen email doesn't exist in a…

[seamuslee001]

… profile

Overview

This Fixes a regression whereby the form variable showMainEmail is being wrongly set to true when the email field exists in the profile. This is a regression from 5.70 specifically ee88ac2#diff-9319a4134599e85c273c3be5706ffb5d642b7659904fd644dd4273791467384aR345 where the showMainEmail was only true previously where ccid was empty AND emailExists is FALSE

Before

Email field potentially being shown twice

After

Email field shown correctly if no profile shows it

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[demeritcowboy]

The PR looks right, but I'm a little confused because on the test site here if I add a profile that does not have an email field, then for some reason it causes the email field not to appear at all. See http://core-29749-a9e.test-1.civicrm.org:8001/civicrm/contribute/transact?reset=1&id=1

[seamuslee001]

Thanks @demeritcowboy I think I have found the problem can you re-check?

[demeritcowboy]

problemExists = FALSE