Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Search accordion, updates class name for lighter accordion #29713

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

vingle
Copy link
Contributor

@vingle vingle commented Mar 13, 2024

The advanced search page is two template files - both adopted a combination of the new <details> accordion pattern with the old classnames during the Dec23 sprint. The other template file was fixed in #29704, this one was missed because it only appears on a search for .crm-master-accordion-header and the visual impact in Greenwich is tiny (in other themes it stands out more).

Before

Old classname. Barely noticeable via the bold text:
image

After

New classname. Text follows same appearance as other lighter style accordions.
image

Comments

I missed this in that last PR, sorry - the visual difference is tiny, but from a theming perspective this change should mean all of the old css accordion classnames aren't being used any more by core.

Fixes transitional details/old classname combo.
Copy link

civibot bot commented Mar 13, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.72 label Mar 13, 2024
@eileenmcnaughton
Copy link
Contributor

test fails unrelated

@eileenmcnaughton eileenmcnaughton merged commit d0abf18 into civicrm:5.72 Mar 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants