Advanced Search accordion, updates class name for lighter accordion #29713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advanced search page is two template files - both adopted a combination of the new
<details>
accordion pattern with the old classnames during the Dec23 sprint. The other template file was fixed in #29704, this one was missed because it only appears on a search for.crm-master-accordion-header
and the visual impact in Greenwich is tiny (in other themes it stands out more).Before
Old classname. Barely noticeable via the bold text:
![image](https://private-user-images.githubusercontent.com/1175967/312648104-1b12b88b-31b0-4076-aea3-8c4a8d4889a6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODk3NjQsIm5iZiI6MTczOTU4OTQ2NCwicGF0aCI6Ii8xMTc1OTY3LzMxMjY0ODEwNC0xYjEyYjg4Yi0zMWIwLTQwNzYtYWVhMy04YzRhOGQ0ODg5YTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDMxNzQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTEwMGU3OWRiOGZmYjU4MTM4NDNhNzExM2UwMDQ3MmRjYjA2MDQ0NjY4ZTBlYjJlMGMzMGJlMTUyOTgyY2FiYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ajuxsWLa7ORDk4zNKslqmzHsH35jxCtwgkDrt2NXYDQ)
After
New classname. Text follows same appearance as other lighter style accordions.
![image](https://private-user-images.githubusercontent.com/1175967/312648269-1204197d-344e-40ed-af08-f652f384fbef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODk3NjQsIm5iZiI6MTczOTU4OTQ2NCwicGF0aCI6Ii8xMTc1OTY3LzMxMjY0ODI2OS0xMjA0MTk3ZC0zNDRlLTQwZWQtYWYwOC1mNjUyZjM4NGZiZWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDMxNzQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTRiN2IwMzhkMWU2M2ZlYTA2MzJhMmIzM2QzNmE4OGMyODUzMzk3ZTNlNjc2NGUwMDRjNDlkNmEwNjAzOWVjMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.TMU8LBcw3ARnSJWlKAFBuunitnG0cgLtwZaRw-p-6t8)
Comments
I missed this in that last PR, sorry - the visual difference is tiny, but from a theming perspective this change should mean all of the old css accordion classnames aren't being used any more by core.