SearchKit - Update crmSearchAdminFields.html to use X icon instead of ban icon for removing fields

[kapn1966]

Confusing icon choice. Should be trash rather than ban.

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civicrm-builder]

Can one of the admins verify this patch?

[civicrm-builder]

Can one of the admins verify this patch?

[seamuslee001]

Jenkins add to whitelist

[mmyriam]

Reviewing this PR at CiviCamp Montreal and several of us here think that the icon used to remove the field in the Select Fields tab should be the same icon used to remove the column in the preview at the bottom of the screen. Currently the X is used. Using the trash bin would cause clutter. Also the tooltips should be consistent.

Necessary changes:

• X for icon in top list
• "Remove" for tooltip in bottom table

[kapn1966]

I think mmyriam's proposal makes even more sense. It would be visually quieter and improve clarity and consistency.
I guess that would need to be a new PR to replace this one?

[mmyriam]

Glad you agree. Actually you can just modify this PR if you are comfortable doing that.

[mmyriam]

P.S. Thanks!

[kapn1966]

I'm fine with the idea, but not really sure about how to do it. I guess I just try to make further code changes in this automatically created branch?

[mmyriam]

Correct. Ideally you just need to make sure none of the files you are changing have been updated since the branch was created. I want to help but I'm not an expert so if it's too complicated you can open a new PR, link to this one and close this one. Or we can ask @colemanw to teach us the best practice.

[kapn1966]

I have managed to changed the icon choice for this PR to an X, but I can't figure our how to add files to make the change from "clear" to remove as you suggest in the lower section. What happens now to this change? Do you approve? Or someone else?

[mmyriam]

I will review this PR. You can make the tooltip change in a different PR.

[mmyriam]

Confirming that icon is changed in Select Fields tab of SearchKit configuration.

Still to do:

• Change tooltip to Remove in preview
• Change icon to X (fa-times) in displays

[kapn1966]

I'll try to track down those other file locations and make the changes you suggest. I'm thinking Thursday afternoon ET.

[mattwire]

@kapn1966 Please follow up with the other changes in a new PR