Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useFakeSession during install on Standalone #29487

Closed

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Feb 23, 2024

Use a fake session during Standalone install, because we might not have the real session handler yet (because the extension that provides it hasn't been installed),

Before

Standalone web installer crashes because of trying to start a session during the install, before standaloneusers extension is enabled to provide the session handler.

After

Install completes successfully.

Technical details

I tried @totten 's suggestion here #29362 (comment) but it didn't seem to work. Because the Civi-bootstrap phase forces recreating the CRM_Core_Config singleton, the fakeness is lost.

I was also keen possible session creation during install by any pesky CRM_Core_Session::setStatus calls -- this doesn't work for that case because it's inside the $loadFromDB case, and at the beginning of the install we're not loading from DB.

The alternative that did cover this case is to put a check inside CRM_Core_Session::singleton, but this seems quite aggressive. (Ie. #29488 )

After all this I'm thinking the initial approach of using default PHP session handler might be the neatest way. For one thing it keeps the Standalone specific code inside userSystem, which seems desirable.

Copy link

civibot bot commented Feb 23, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@artfulrobot
Copy link
Contributor

Closing as #29352 merged.

@artfulrobot artfulrobot closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants