SMS Trait - add support for Autocomplete subscriber, notice fix #29429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SMS Trait - add support for Autocomplete subscriber, notice fix
This just pulls out the Smarty notice fix, the function moves & the registration for the phone autocomplete widget from #29413 because there is still a bit to work through in there & these fixes can be added by themselves
Before
@colemanw's autocomplete support not in core, notice on SMSTemplate
![image](https://private-user-images.githubusercontent.com/336308/305751466-30a1c39f-b986-401d-8a06-0bbe4c39a686.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTAxNDUsIm5iZiI6MTczOTU4OTg0NSwicGF0aCI6Ii8zMzYzMDgvMzA1NzUxNDY2LTMwYTFjMzlmLWI5ODYtNDAxZC04YTA2LTBiYmU0YzM5YTY4Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwMzI0MDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zNDM4MjIwZDIyN2FmMjVjNWUzYWY1YmMzMGE5NGE3N2E4MTdjYzQyOWFmYmQ2YzUzNDU3YTBmNTUyYWViMjRjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.4T8T7PN9QKhc0-7nRzJZyyzactvGRqUjKovPoM5-utI)
Functions not in the trait
After
Above chunks done
Technical Details
@colemanw I think this will simplify working through the remaining parts
Comments