[REF] DAO - Make getEntityIcon()
function more useful
#29423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Makes getter function work all the time, not just when passed an id.
Before
No general getter function for
DAO_*::$_icon
, which requires direct access to internal class variable.BAO:getEntityIcon()
only works when passed an id.After
BAO:getEntityIcon()
works as a getter function both for a specific entity, and also for the entity in-general.