Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP Notice in Contact Import Parser #29396

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix PHP Notice in Contact Import Parser #29396

merged 1 commit into from
Feb 15, 2024

Conversation

ejegg
Copy link
Contributor

@ejegg ejegg commented Feb 15, 2024

e.g.
coworker[3112893]: [PHP Notice] Undefined index: custom_348 at sites/all/modules/civicrm/CRM/Contact/Import/Parser/Contact.php:391

Overview

Fixes an e-notice when importing a contact with custom fields

Before

notices in coworker log

After

No notices in coworker log

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@ejegg
Fix PHP Notice in Contact Import Parser
d7479b0 
e.g.
coworker[3112893]: [PHP Notice] Undefined index: custom_348 at
sites/all/modules/civicrm/CRM/Contact/Import/Parser/Contact.php:391
@civibot civibot
Copy link

civibot bot commented Feb 15, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 15, 2024
@eileenmcnaughton eileenmcnaughton merged commit 7cf8b42 into civicrm:master Feb 15, 2024
3 checks passed
wmfgerrit pushed a commit to wikimedia/wikimedia-fundraising-crm that referenced this pull request Feb 15, 2024
@ejegg
Fix notice in Contact Import Parser
4f9b4ea 
See civicrm/civicrm-core#29396

Bug: T356947
Change-Id: I3d0350de87ba33669f0638cc8e20747b6e51ee0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejegg @eileenmcnaughton