dev/core#4026 Fix failure to save membership data on submit when membership type changed

[eileenmcnaughton]

Overview

dev/core#4026 Fix failure to save membership data on submit when membership type changed

This also fixes php8.2 issues with the form

Before

For full steps go to https://lab.civicrm.org/dev/core/-/issues/4026

In my testing I created 2 custom data groups extending membership, one extending the type 'student' and one extending the type ' and trying switching between the 2 membership types on edit - checking what was in the email receipt & what displayed when re-viewing - as per the reproduction steps the value did not update on the first save

After

fixed

Technical Details

There is already a WIP PR at #25215 by @braders & in review @larssandergreen identified 2 issues on that PR which also needed to be addressed in this PR

• on reload the entered data did not appear - I put the patch for that on the rc as the participant form is affected in the rc BackOffice participant form - Fix failure to reload correct default when custom data subtype changes #29356 (I will rebase out if merged)
• sub-type specific custom fields not saved on new register

Comments

I worked on this over #29348 which is in the PR but I expect that to be merged & then I can rebase out

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4026

[eileenmcnaughton]

Cool thanks