dev/core/-/issues/2915 Replace 'Expose Publicly' with 'Public Pages' which is less offensive for some demographics

[agileware-justin]

Overview

Fix inconsistent use of 'Expose Publicly' to consistently use 'Public Pages'.

'Public Pages' is less offensive for some demographics than 'Expose Publicly' which has also been noted by our users more than once. See related proposal https://lab.civicrm.org/dev/core/-/issues/2915

This also aligns the Group listing with the updated SearchKit Group Listing which does use the consistent terminology of 'Public Pages'.

Before

"Expose Publicly" is shown in the Group listing (pre Searchkit / AdminUI) and then differently on the Group Settings page, displaying the same option as "Public Pages", this inconsistency is confusing.

The code internally uses the terminology "Public Pages" which is then replaced on the front-end with "Expose Publicly".

After

Consistent use of terminology, "Public Pages".

Technical Details

Comments

Agileware Ref: CIVICRM-1870

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

I'm + 1 on this change

[agileware-justin]

@colemanw "and for" begone!

[colemanw]

Seems good. Would you be able to squash those commits down to one?

[agileware-justin]

Squashed @colemanw

[colemanw]

Thanks @agileware-justin. This PR has the merge-ready tag so if there are no objections it should be merged in the next week.

[yashodha]

@agileware-justin looks good, merging this PR.