CryptoJwt - Fix detection of firebase/php-jwt APIs

[totten]

Overview

5.70's #28971 introduced a different check for detecting firebase/php-jwt APIs. It distinguishes Firbase JWT v5.x from v6.0 -- but then it misinterprets v6.6+ and crashes.

(ping @seamuslee001 @mattwire)

Before

If you have firebase/php-jwt v6.6+, then it chooses the wrong behavior and gives it the v5.x-style call. This leads to errors like:

Error: Cannot pass parameter 3 by reference in Civi\Crypto\CryptoJwt->decode() (line 92 of /Users/totten/bknix/build/build-0/vendor/civicrm/civicrm-core/Civi/Crypto/CryptoJwt.php)

#0 /Users/totten/bknix/build/build-0/vendor/civicrm/civicrm-core/ext/authx/Civi/Authx/CheckCredential.php(96): Civi\Crypto\CryptoJwt->decode('')
#1 [internal function]: Civi\Authx\CheckCredential->bearerJwt(Object(Civi\Authx\CheckCredentialEvent), 'civi.authx.chec...', Object(Civi\Core\UnoptimizedEventDispatcher))

After

That works.

Technical Details

The reason why the test from 28971 doesn't work is that the method signature has been moving around:

• https://github.com/firebase/php-jwt/blob/v5.4.0/src/JWT.php#L79
• https://github.com/firebase/php-jwt/blob/v5.5.0/src/JWT.php#L82
• https://github.com/firebase/php-jwt/blob/v6.0.0/src/JWT.php#L85
• https://github.com/firebase/php-jwt/blob/v6.6.0/src/JWT.php#L99

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[totten]

For comparison, kicked off an E2E test-run of the PR with drupal9-clean: https://test.civicrm.org/job/CiviCRM-Manual-Test/120/

[totten]

@seamuslee001 Looks like this passed on drupal-clean and drupal9-clean. (The failure in testLocalizedData is pre-existing/unrelated.)

[mattwire]

Thankyou @totten!