Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add class for fee level column #29123

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

pradpnayak
Copy link
Contributor

Overview

Find participant results has classes for all the columns besides for Fee Level column, this PR adds class to the column so that it can used as reference if needed to alter the column via JS or CSS

Copy link

civibot bot commented Jan 28, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 28, 2024
@colemanw
Copy link
Member

colemanw commented Feb 1, 2024

The existing code is weird. It looks like there's an {if} conditional that controls what goes inside the <td> but there is a <td> added in either case, just one of them had a css class and the other one was missing the class. You've added the class so now they are both the same, which means the <td> markup could logically be moved outside of the conditional since it's really being added unconditionally.

@pradpnayak
Copy link
Contributor Author

Hi @colemanw

I have amended the changes. Can you please review now?

Thanks
Pradeep

@colemanw
Copy link
Member

That makes a lot more sense. Thanks @pradpnayak

@demeritcowboy demeritcowboy merged commit db70085 into civicrm:master Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants