Fix fatal on Manage Extensions caused by financialacls links

[mlutfy]

Overview

Fixes a fatal on https://smaster.demo.civicrm.org/civicrm/admin/extensions?reset=1

TypeError: financialacls_civicrm_links(): Argument #3 ($objectID) must be of type ?int, string given, called in CRM/Utils/Hook.php on line 292 in financialacls_civicrm_links() (line 387 of ext/financialacls/financialacls.php).

Technical Details

When visiting Manage Extensions, the objectId passed to the hook, is the string name of the extension (ex: authx).

Maybe we should not call the hook from Manage Extensions? I can imagine any ext author doing this mistake, and only realizing the bug much later.

Very recent regression: ce6cca3 - and does not seem to be in the RC yet.

cc @eileenmcnaughton

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

@seamuslee001 I think the documentation might be out of date then - we should rename the variable

[mlutfy]

Is this the right format? https://lab.civicrm.org/documentation/docs/dev/-/merge_requests/1114