APIv4 - Fix html encoding of rich-text fields #26251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
In ece8de2 this was fixed but only for APIv3, and with no unit test. The previous fix also did not cover fields using "TextArea" as their input type, even though they are allowed to store HTML. This fixes for APIv4 and v3 and adds a test. and adds a test.
|
@demeritcowboy funny that the unit test added in d80e8fa#diff-6a4e0910b489565b79b2cc8b5786e9345b9b955c4557981dc7614b04e7e5451eR19 includes a case for Windows... but intentionally fails that case. |
|
I think it's that absolute paths are supposed to fail, so that is probably correct. But yeah I can try adding one that should pass. |
|
Test added at #26285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the same bug in APIv4 that was fixed for v3 in #12841
See https://chat.civicrm.org/civicrm/pl/oc55t77c3iyetehua71zwbqi5y
Before
Rich text custom fields do not display correctly if saved via APIv4.
After
Fixed.
Technical Details
In ece8de2 this was fixed but only for APIv3, and with no unit test. The previous fix also did not cover fields using "TextArea" as their input type, even though they are allowed to store HTML.
This fixes APIv4 and v3 and adds a test for both.