Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiviEvent Import - Remove broken call to parent constructor (dev/core#3932) #24790

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

brienneK
Copy link
Contributor

@brienneK brienneK commented Oct 21, 2022

Overview

Resolves Issue 3932 on lab.civicrm, in which the Event Participant Import attempts to call a parent constructor that does not exist

Before

Before this patch, when a user goes to Events > Import Participants, fills out the first screen and then clicks Continue they receive a critical error.

After

With this patch, when a user follows the above steps, they move on to the second screen of the import process (field mapping).

Technical Details

Removed line 68 within the __construct function (aka constructor) within Participant.php that attempted to call a constructor in CRM_Import_Parser, though one does not exist.


@civibot
Copy link

civibot bot commented Oct 21, 2022

(Standard links)

@civibot civibot bot added the 5.55 label Oct 21, 2022
@kcristiano
Copy link
Member

I've done an r-run and this works as expected. This looks good to merge.

@seamuslee001 seamuslee001 merged commit c1b6ed2 into civicrm:5.55 Oct 21, 2022
@Freewindrider
Copy link

I've tested this successfully in a live-environment.
Thank you very much for your work on this.

@totten totten changed the title Remove broken call to parent constructor (Issue #3932) CiviEvent Import - Remove broken call to parent constructor (dev/core#3932) Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants