Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3853 - Still need the exception aliases #24550

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

demeritcowboy
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/core/-/issues/3853

Before

  • Can't install civirules.
  • Or any code that references API3_Exception or CiviCRM_API3_Exception probably doesn't work as expected.

After

Technical Details

Comments

One way to quickly see this is run cv -vvv ev "try { civicrm_api3('OptionGroup', 'getsingle', ['name' => 'aaaaaaaaa']); } catch (CiviCRM_API3_Exception $e) { echo 'should be here'; }". It should get caught (assuming you don't have an option group named aaaaaaaaa).

@civibot
Copy link

civibot bot commented Sep 18, 2022

(Standard links)

@civibot civibot bot added the master label Sep 18, 2022
@seamuslee001 seamuslee001 merged commit 79f8656 into civicrm:master Sep 18, 2022
@demeritcowboy demeritcowboy deleted the exception branch September 18, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants