dev/core#3799 - Fix incorrectly changed default for contact_dashboard.is_active

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/3799

Before

1. Save a civireport and check the box on the access tab for make available for dashboard.
2. Visit /civicrm and note it's been automatically added to your dashboard and everyone else's. It's only supposed to be available not active yet.

After

Like it was before.

Technical Details

There were a couple defaults changed in this and other related PRs: c1e814c#diff-3115bab5eca8c2816b16ab416da5fc063a17034d9c2152f5dcef498362faeb27R200

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[agileware-justin]

Have confirmed this PR on the TEST SITE. New reports are not being automatically added to the Dashboard when the Available on Dashboard option is selected. PR fixes this regression.

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained, see https://lab.civicrm.org/dev/core/-/issues/3799
  • User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: Confirmed working on the TEST SITE, http://site-list.test-1.civicrm.org/?filter=core-24238-*
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change does not sufficiently improve test coverage, but special circumstances make it important to accept the change anyway.
  • Test results (r-test)
    • COMMENTS: No specific unit tests.