CrmUi - Fix crmSelect2 to work with ngOptions #24224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of civicrm#23749 select elements using ui-jq were switched to crm-ui-select, which should have been a drop-in replacement, but it turns out it broke for widgets using ngOptions. This fixes it. Fixes dev/core#3797
|
(Standard links)
|
|
worked for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes bug reported in dev/core#3797
Before
Select elements using
ngOptionsbroken, such as those in CiviMail.After
Fixed.
Technical Details
As part of #23749 select elements using
ui-jqwere switched tocrm-ui-select, which should have been a drop-in replacement, but it turned out to be incompatible withngOptions. This fixes it.