Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrmUi - Fix tabSetOptions variable #24193

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 9, 2022

Overview

Fixes JS error caused by #23749 refactoring.

Before

JS Error when using the MapPins extension.

After

Core code is now correct. I'll submit a PR to MapPins because they are still treating the object as if it were a string.

Technical Details

Prior to #23749 this had been passing an object around as a string.
During the refactoring it was treated as an object but still left as a string param.
Now it's passed as an object.

Prior to civicrm#23749 this had been passing an object around as a string.
During the refactoring it was treated as an object but still left as a string param.
Now it's passed as an object.
@civibot
Copy link

civibot bot commented Aug 9, 2022

(Standard links)

@civibot civibot bot added the 5.52 label Aug 9, 2022
@totten
Copy link
Member

totten commented Aug 9, 2022

There appears to be no discoverable impact outside of that extension, so the only question is whether the change might cause some other regression. So I did some r-run on the wizard widget - and it seems to behave as well as before.

(Note that I found a different/pre-existing bug in the wizard; but it originated a few years ago, so I filed separately as https://lab.civicrm.org/dev/core/-/issues/3791.)

@colemanw Note that this needs an explicit port for 5.53/master.

@totten totten merged commit 0839d90 into civicrm:5.52 Aug 9, 2022
@colemanw colemanw deleted the tabSetOptions branch August 9, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants