Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to CiviAuction #24187

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 9, 2022

Before

💩 LOL 🎱 IDK 🤷

After

🪄 ☁️

@civibot
Copy link

civibot bot commented Aug 9, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor

hmm

@colemanw
Copy link
Member Author

colemanw commented Aug 9, 2022

Maybe someone was trying to build an open-source Ebay?

@seamuslee001
Copy link
Contributor

Going once, Going Twice ..........

@seamuslee001
Copy link
Contributor

@JoeMurray was this one of your bright ideas?

@eileenmcnaughton
Copy link
Contributor

ohh - @demeritcowboy as the reiging champion of clever PR comments you might have a challenge to beat ^^

@demeritcowboy
Copy link
Contributor

Maybe somebody said "we need to be able to add option items" and it got misheard.

@demeritcowboy
Copy link
Contributor

But my vote is for "Going once, Going Twice"

Anyway looks like civicrm/civicrm-svn@5713179

and

https://issues.civicrm.org/jira/browse/CRM-15918

@eileenmcnaughton
Copy link
Contributor

lol - well I'm glad I've been consistent on it...

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton eileenmcnaughton merged commit ea4ec58 into civicrm:master Aug 9, 2022
@eileenmcnaughton eileenmcnaughton deleted the removeCiviAuction branch August 9, 2022 07:55
@colemanw
Copy link
Member Author

colemanw commented Aug 9, 2022

Going... going... gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants