SearchKit - Fix viewing search display for anonymous user #24160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in aa5d068 when the single SearchDisplay::run api call was replacd with an array of calls. The hack in alterApiRoutePermissions can't handle multiple calls. This updates it so that it can handle an array of calls - it will call the hook for each one and reject the request if any of them lack permission.
|
(Standard links)
|
|
I did some To my reading, this improves support for The conditional was a little mysterious at first - but after comparing the related code in Merge on pass. |
This was referenced Aug 8, 2022
|
We haven't branched yet so I'm just wondering whether this is already merged to master (which is kinda the rc) - since we won't up-merge this branch |
|
@eileenmcnaughton the master branch version of this PR is at #24180 |
|
Yeah, to minimize shuffling, we'll branch for 5.53-rc after the current batch of regression-fixes (circa 5.52.1) are merged into master+5.52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes anonymous access to SearchKit displays.
Before
Anonymous user cannot view SearchKit display, even if it is set to bypass permission checks.
After
It works again.
Technical Details
This regressed in aa5d068 when the single SearchDisplay::run api call was replaced with an array of calls. The gatekeeper
CRM_Api4_Permissionwas only able to handle single calls.This updates it so that it can handle an array of calls - it will call
hook_civicrm_alterApiRoutePermissionsfor each one and reject the request if any of them lack permission.