Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 export action: find DAO by ID instead of just calling the constructor and setting the ID #24089

Merged
merged 1 commit into from
Jul 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Civi/Api4/Generic/ExportAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ private function exportRecord(string $entityType, int $entityId, Result $result,
$daoName = CoreUtil::getInfoItem($entityType, 'dao');
if ($daoName) {
/** @var \CRM_Core_DAO $dao */
$dao = new $daoName();
$dao->id = $entityId;
$dao = $daoName::findById($entityId);
// Collect references into arrays keyed by entity type
$references = [];
foreach ($dao->findReferences() as $reference) {
Expand Down