Remove call to loadRelatedObjects from completetransaction
#24087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
complete
branch
from
bd16bb1
to
a12eb25
Compare
| @@ -3304,7 +3304,7 @@ public function testCompleteTransactionSetStatusToInProgress($dataSet) { | |||
| ]) | |||
| ); | |||
| $this->callAPISuccess('Contribution', 'completetransaction', [ | |||
| 'id' => $contribution, | |||
| 'id' => $contribution['id'], | |||
There was a problem hiding this comment.
Hmm - this was always wrong - must have been cast to 1 before....
eileenmcnaughton
force-pushed
the
complete
branch
from
221ce8c
to
e70480b
Compare
|
tests passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove call to
loadRelatedObjectsfromcompletetransactionBefore
Legacy cruft call
loadRelatedObjectssometimes causes noticesAfter
poof
Technical Details
This call is has been removed from the other places (Paypal & Authorize.net) that call
completeOrder. The values it loads are no longer passed in/ usedThe only one that is a bit confusing is
amount- this is actually a copy & paste legacy from when the coede was shared withrepeattransactionwhich DOES acceptamountas an input.completeOrder, however, does not allow amount to be changed.Comments
@mattwire - I fixed up some tests to have better data but now they are hitting the e-notice so it feels like a good time to finally rip out this bit of code - the last round (or the one before) of cleanup in
completeOrdermade it obsolete