Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Fix resolving pseudoconstants for less-permissioned users #24086

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

colemanw
Copy link
Member

Overview

Fixes dev/core#3750, with test.

@civibot
Copy link

civibot bot commented Jul 29, 2022

(Standard links)

@civibot civibot bot added the master label Jul 29, 2022
@colemanw colemanw changed the base branch from master to 5.52 August 5, 2022 18:29
@civibot civibot bot added 5.52 and removed master labels Aug 5, 2022
@agileware-justin
Copy link
Contributor

agileware-justin commented Aug 5, 2022

  • General standards
    • Explain (r-explain)
    • User impact (r-user)
      • PASS: The change would be unnoticeable for a majority of users who work with this feature.
    • Documentation (r-doc)
      • PASS: Changes do not require documentation - it is expected functionality.
    • Run it (r-run)
      • PASS: PR works correctly when applied to CiviCRM 5.51.1
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.

@agileware-justin
Copy link
Contributor

Thanks again @colemanw

@agileware-justin
Copy link
Contributor

#readytomerge

@colemanw colemanw merged commit 6886ee5 into civicrm:5.52 Aug 6, 2022
@colemanw colemanw deleted the fixTagFilter branch August 6, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants