dev/core#3749 Fix process pledges to throw exception when civiPledge disabled #24059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…disabled Per the issue - it's fine for the job to not work if disabled, but the error should be logical. updatePledgeStatus is only called from one place so made the return handling flatter for success, and exception on error
eileenmcnaughton
force-pushed
the
pledged
branch
from
a507a7e
to
adca269
Compare
|
Thanks @eileenmcnaughton looks good to me |
|
Merging based on @agileware-justin review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lab.civicrm.org/dev/core/-/issues/3749
…
Per the issue - it's fine for the job to not work if disabled,
but the error should be logical.
updatePledgeStatus is only called from one place so made the return
handling flatter for success, and exception on error