dev/financial#201 Fix PaypalPro IPN to refer to correct option group #24050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
|
This seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix PaypalPro IPN to refer to correct option group
Before
Paypal pro is looking up the options in the Contribution.contribution_status_id option group when it wants the valid statuses for recurrings. This works OK at the moment but when we remove 'In Progress from the Contribution status option group it won't work anymore.
After
It correctly gets statuses from the contribution recur. contribution_status_id option group
Technical Details
This has test cover - notably in CRM_Core_Payment_PayPalProIPNTest::testIPNPaymentExpressRecurSuccess - which was the test that highlighted it as having the dependency in PR #23074
Comments