Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActionLog BAO to not overwrite existing data #24035

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

colemanw
Copy link
Member

Overview

I spotted what looks like a bug in this BAO code. create functions in the BAO serve a double-duty, they are also used for update. So when setting defaults, one must be careful to check which operation is happening before possibly overwriting existing data.

Before

Default set unconditionally, existing data overwritten.

After

Default only set for create action.

@civibot
Copy link

civibot bot commented Jul 21, 2022

(Standard links)

@civibot civibot bot added the master label Jul 21, 2022
@seamuslee001 seamuslee001 merged commit 33113e9 into civicrm:master Jul 21, 2022
@seamuslee001 seamuslee001 deleted the actionLogFix branch July 21, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants