Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fontawesome icon helper for activity/Page/AJAX #24021

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Jul 19, 2022

Overview

This fixes a missing delete icon on case roles on some themes.

image

Before

Delete icon missing on some themes (not using fontawesome)

After

Delete icon switched to fontawesome and shows.

Technical Details

Also converts the rest of the icons in the activity/Page/AJAX class to use the icon helper.

Comments

@civibot
Copy link

civibot bot commented Jul 19, 2022

(Standard links)

@civibot civibot bot added the master label Jul 19, 2022
@demeritcowboy demeritcowboy merged commit bbed325 into civicrm:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants