APIv4 - Fix mishandling of boolean custom values #23970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
MegaphoneJon
force-pushed
the
false-not-zero
branch
from
22d9131
to
04921c2
Compare
colemanw
changed the title
|
@MegaphoneJon I've updated this PR with a fix. I wasn't sure if I should limit the fix to just custom fields, or if it was appropriate to convert every field. Considering how inconsistent our BAO code is, I think the blanket fix might prevent other edge-case bugs like this one so I've tried that and we'll see how the test suite likes it. |
|
This seems fine to me and has a unit tests merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes https://lab.civicrm.org/dev/core/-/issues/3497 to correctly save boolean custom field values.
Before
APIv4 would store FALSE as NULL.
After
Boolean fields correctly saved.