Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Consistently check for date field #23354

Merged
merged 1 commit into from
May 4, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 4, 2022

Overview

Followup from #23335, makes the logic more consistent between rendering and initializing a date widget.

Before

Fields like Contact.created_date are rendered with a datePicker as of #23335 but when loading a saved search they might not get initialized correctly in the UI.

After

Works better.

@civibot
Copy link

civibot bot commented May 4, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

unrelated fail

image

@eileenmcnaughton eileenmcnaughton merged commit 72eaf83 into civicrm:master May 4, 2022
@eileenmcnaughton eileenmcnaughton deleted the searchKitDateField branch May 4, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants