Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop adding obsolete currencies to new installs #23345

Merged
merged 1 commit into from
May 4, 2022

Conversation

@civibot
Copy link

civibot bot commented May 3, 2022

(Standard links)

@civibot civibot bot added the master label May 3, 2022
@eileenmcnaughton eileenmcnaughton changed the title Stop adding Cyprus Pound to new installs Stop adding obsolete currencies to new installs May 3, 2022
@eileenmcnaughton
Copy link
Contributor Author

I was a bit surprised to find this lot in there

(167, "XAG", NULL, "961", "Silver"),
(168, "XAU", NULL, "959", "Gold"),
(169, "XBA", NULL, "955", "Bond Markets Units European Composite Unit (EURCO)"),
(170, "XBB", NULL, "956", "European Monetary Unit (E.M.U.-6)"),
(171, "XBC", NULL, "957", "European Unit of Account 9 (E.U.A.-9)"),
(172, "XBD", NULL, "958", "European Unit of Account 17 (E.U.A.-17)"),
(173, "XCD", "$", "951", "East Caribbean Dollar"),
(174, "XDR", NULL, "960", "Special Drawing Right"),
(175, "XFO", NULL, NULL, "Gold-Franc"),
(176, "XFU", NULL, NULL, "UIC-Franc"),
(177, "XOF", NULL, "952", "CFA Franc BCEAO"),
(178, "XPD", NULL, "964", "Palladium"),
(179, "XPF", NULL, "953", "CFP Franc"),
(180, "XPT", NULL, "962", "Platinum"),
(181, "XTS", NULL, "963", "Code for testing purposes"),
(182, "XXX", NULL, "999", "No currency involved"),

@seamuslee001
Copy link
Contributor

look i'm sure you can still pay for things in gold right?

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 that's not the problem - it's the people who won't take my XTS!

@seamuslee001 seamuslee001 added the merge ready PR will be merged after a few days if there are no objections label May 3, 2022
@seamuslee001
Copy link
Contributor

this seems ok to me merge ready

@colemanw colemanw merged commit 5a4d739 into civicrm:master May 4, 2022
@colemanw colemanw deleted the cypr branch May 4, 2022 19:27
@colemanw
Copy link
Member

colemanw commented May 4, 2022

I guess this means no one will be able to donate to CiviCRM using platinum. But we still accept code for testing purposes!

@eileenmcnaughton
Copy link
Contributor Author

@colemanw I didn't remove platinum....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants