[REF] [Import] [Trivial] Make mapperKeys parameter optional in construct

[eileenmcnaughton]

Overview

[REF] [Import] [Trivial] Make mapperKeys parameter optional in construct

Before

$mapperKeys is a required reference parameter & hence it is necessary to instantiate an empty array when called with an empty array (as happens in the DataSource usage ++)

After

optional parameter

Technical Details

@colemanw @demeritcowboy @seamuslee001 @totten - I'm trying to pull out some of the trivial changes that pretty much all PRs require into tiny PRs like this to try to get them merged & reduce the conflicts - would be good to get this merged & then I can rebase all the others that include some form of it

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Also #23308

[demeritcowboy]

I guess this is ok. I'm not sure what &$x means when $x is created as a default parameter value, but php seems ok with it.

[eileenmcnaughton]

@demeritcowboy - yeah those &$ could go too tbh - they are already gone from some - shall I pull them out as well so no-one has to think about them ever again?

[demeritcowboy]

shall I pull them out as well so no-one has to think about them ever again

Maybe in another PR. I haven't personally looked at what it would change. Whereas just making it optional doesn't seem to change anything.

[eileenmcnaughton]

@demeritcowboy ok - I think the params will wind up disappearing anyway - depending how far I get - I don't think they are actually the right eventual params but I think we need to stop saving labels & save names instead per #23288 before we can do things in a sane way