Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - Improve dragging into dropzones #23239

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

colemanw
Copy link
Member

Overview

Improves the drag-n-drop UX in Afform when composing complex layouts.

Before

Frustrating. Elements don't seem to want to fit into columns.

After

Less frustrating.

Comments

As requested by @eileenmcnaughton

@civibot
Copy link

civibot bot commented Apr 18, 2022

(Standard links)

@civibot civibot bot added the master label Apr 18, 2022
@eileenmcnaughton
Copy link
Contributor

Merging as a definitely improvement - in r-running I hit a couple of issues with search kit

  • I tried to do a search with count(contact_id) GROUP BY contact_type - & .... no data

http://core-23239-12k5h.test-1.civicrm.org:8001/civicrm/admin/search#/edit/2

then I tried to export it & import locally & that failed to import (maybe I don't have formbuilder enabled locally - will check but if so it failed pretty ungracefully)

also - I thought we fixed it so you could use aggregates without GROUP BY - eg SELECT SUM(total_amount) FROM civicrm_contribution WHERE receive_date > '2022-08-09'

@eileenmcnaughton eileenmcnaughton merged commit 0f4b341 into civicrm:master Apr 18, 2022
@eileenmcnaughton eileenmcnaughton deleted the afformLineup branch April 18, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants