Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] [Import] Remove another good intention....mapField #23236

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

The mapField() function in the import parser classes looks like a good intention - in every instance it does nothing except

  1. makes the code hard to read
  2. returns the same constant.

It currently has to be implemented due to the abstract function - but does nothing helpful.

Before

blah blah blah

After

poof

Technical Details

I have removed the pattern from csvimporter just now - but not the civiHR classes that extend this abstract class as it doesn't matter if they DO continue to implement the function - it's just fugly

Comments

@civibot
Copy link

civibot bot commented Apr 18, 2022

(Standard links)

@civibot civibot bot added the master label Apr 18, 2022
@colemanw
Copy link
Member

Code simplification makes sense.

@colemanw colemanw merged commit e1e79a5 into civicrm:master Apr 18, 2022
@colemanw colemanw deleted the mapField branch April 18, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants