Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodefaults to group edit form #23225

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Apr 15, 2022

Overview

Add smarty:nodefaults to URLs in the group edit form.

Before

The links were broken in some environments (as previously noted on other PRs, this does not currently affect Drupal, due to differing URL strucutres between CMSs).

After

The links work.

@civibot
Copy link

civibot bot commented Apr 15, 2022

(Standard links)

@civibot civibot bot added the master label Apr 15, 2022
@eileenmcnaughton
Copy link
Contributor

@braders thanks! Maybe we should remove the drupal by-passes that don't work on Wordpress?

@eileenmcnaughton eileenmcnaughton merged commit 764746c into civicrm:master Apr 15, 2022
@braders
Copy link
Contributor Author

braders commented Apr 15, 2022

@eileenmcnaughton I have a fair few more problematic URLs lined up to open PRs for first, but once that's done I totally agree the bypass which only works in Drupal should go.

@eileenmcnaughton
Copy link
Contributor

@braders yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants